Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link Validation section #270

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

AbhishekReddy1127
Copy link
Contributor

@AbhishekReddy1127 AbhishekReddy1127 commented Feb 3, 2023

Signed-off-by: AbhishekReddy1127 [email protected]

Description

Updated the links to the Opensearch website in the Links section.

Screenshot 2023-02-07 at 2 05 23 PM
Screen Shot 2023-02-02 at 11 01 18 PM

Issues Resolved

#210

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AbhishekReddy1127 AbhishekReddy1127 marked this pull request as ready for review February 3, 2023 07:04
@AbhishekReddy1127 AbhishekReddy1127 requested a review from a team as a code owner February 3, 2023 07:04
Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct Opensearch to OpenSearch

src-docs/src/views/link/link.js Outdated Show resolved Hide resolved
src-docs/src/views/link/link.js Outdated Show resolved Hide resolved
Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: AbhishekReddy1127 <[email protected]>
Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the text from the last review!

@KrooshalUX
Copy link
Contributor

One note - I am unable to link this to issue 210 using the "development" feature in github, not sure why - calling out to make sure we close the appropriate issue on merge.

@BSFishy BSFishy merged commit 773e661 into opensearch-project:main Feb 20, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2023
* Updated link Validation section

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the incoorect text

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the links

Signed-off-by: AbhishekReddy1127 <[email protected]>

---------

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit 773e661)
seanneumann added a commit that referenced this pull request Feb 28, 2023
* Updated link Validation section

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the incoorect text

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the links

Signed-off-by: AbhishekReddy1127 <[email protected]>

---------

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit 773e661)

Co-authored-by: Abhishek Reddy <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants